feat: modify istio version& add layotto_without_xds
#714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
# Conflicts: # cmd/layotto/main.go
26 tasks
Codecov Report
@@ Coverage Diff @@
## main #714 +/- ##
=======================================
Coverage 60.89% 60.89%
=======================================
Files 122 122
Lines 6432 6432
=======================================
Hits 3917 3917
Misses 2133 2133
Partials 382 382 Continue to review full report at Codecov.
|
zhenjunMa
approved these changes
Jul 12, 2022
Xunzhuo
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: seeflood zhou.qunli@foxmail.com
What this PR does:
modify istio version in main.go
I used to modify istio version with Makefile, but I reverted it because I want the makefile script decoupled with the code.
For example, if the code doesn't import xDS related packages, makefile will get error when trying to modify the istio version.
add
layotto_without_xdsfor non-xDS usersWhich issue(s) this PR fixes:
Fixes #
It's subtask of #471
Special notes for your reviewer:
Does this PR introduce a user-facing change?: